Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to deactivate a genome build #557

Closed
12 tasks done
loeswerkman opened this issue Sep 29, 2021 · 2 comments · Fixed by #558
Closed
12 tasks done

Allow users to deactivate a genome build #557

loeswerkman opened this issue Sep 29, 2021 · 2 comments · Fixed by #558

Comments

@loeswerkman
Copy link
Collaborator

loeswerkman commented Sep 29, 2021

  • Add button to the GB ViewEntry (VE) to deactivate the genome build (like done on other VEs)

  • Show form to deactive GB (/genome_builds/hg19?remove)

    • Just give a warning and require a password, no other fields needed.
  • Give an error and block removal when:

    • The chosen ID is not among the active IDs
    • Password is incorrect
    • There are variants on the chosen genome build that are not yet mapped on one of the other active genome builds
  • Delete entry if all variants are safely mapped on another genome build

    • Delete row from Genome build table
    • Alter VOG table (deleting the start, end, and DNA columns)
    • Deactivate the custom DNA column
    • Alter Transcripts table (deleting the start and end columns)

Related to #550

@ifokkema
Copy link
Member

I've added some steps; it's better to deactivate the GB from its ViewEntry (VE). So the user must first look at the GB ViewList (VL), then click on one, see its details, then click "Options", then "Remove genome build", and then get the form.
The form itself can then just contain a warning (are you sure? blabla) and a password field.
When not all variants are also mapped on another genome build, block removal, not just a warning.
Deleting the entry is probably best done by first deleting the entry from the GB table. If done in any other order, the system will be broken for a short time (or a long time, if something goes wrong).

@loeswerkman loeswerkman mentioned this issue Sep 30, 2021
@ifokkema ifokkema linked a pull request Oct 1, 2021 that will close this issue
@ifokkema
Copy link
Member

ifokkema commented Oct 1, 2021

Closed by #558.

@ifokkema ifokkema closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants