This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
feature: displaying a warning before opening a block explorer link #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a new
UIAlertController
to display an alert to the user when they tap on a block explorer link. I also made a slight refactor to remove thedelegate
that is passed intoEventDetailViewModel.swift
. I replaced it with a more reactive approach to more fully embrace that style of programming within the app.Motivation and Context
This is to address issue #125.
How Has This Been Tested?
On the iOS simulator, I went to the history page, tapped on a transaction and then tapped on both transaction hashes as well as addresses. I verified that the cancel button dismissed the alert in both cases. I also verified that the continue button took us to the correct block explorer page in both instances.
I also went to the channel page and tapped on the funding transactions. I verified that the cancel button dismissed the alert. I also verified that the continue button took us to the correct block explorer page.
Screenshots (if appropriate):
Types of changes
Checklist: