This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Skip certificate validation for tor connections #242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the certificate validation for tor connections completely.
It is not needed as Tor already provides that security.
Motivation and Context
This will it make much more simple to connect to Tor nodes, as there will be no more hostname verification issues.
We had several users of raspiblitz for example that have problems setting this up.
Before the tor hostname had to be part of the lnd.conf as tlsextradomain. No this is not necessary anymore.
Furthermore it allows to not transmit the certificate in the lndconnect string leading to a much less dense QR-Code that is easier to scan.
It also partly fixes issue #203 , but only for tor connections.
Most likely this also fixes #222
How Has This Been Tested?
Tested on my S9
Types of changes
Checklist: