Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for missing 32 bit downloads for nightly #389

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Rossmaxx
Copy link

@Rossmaxx Rossmaxx commented Nov 13, 2024

I've started to remove 32 bit support in the CI. If this gets through, nightlies won't have 32 bit artefacts anymore for windows. There should be a warning to explain the missing artifacts. Per LMMS/lmms#6614 (comment) by @tresf

TODO:

@Rossmaxx

This comment was marked as outdated.

@Rossmaxx
Copy link
Author

LMMS/lmms#7286 is the issue.

Co-authored-by: FyiurAmron <[email protected]>
@tresf
Copy link
Member

tresf commented Nov 13, 2024

I think this PR is misdirected because it removes 32-bit builds from showing EVEN WHEN THEY'RE BUILT EVEN FOR PAST BUILDS. This doesn't really make sense. If we're to stop building 32-bit builds moving forward on the main repository, it'll save us CI time and they'll just stop appearing on our PRs and nightly pages.

@tresf
Copy link
Member

tresf commented Nov 13, 2024

[ ] Download link broken for some reason after this change.

Probably GitHub rate limiting on your PC.

The primary rate limit for unauthenticated requests is 60 requests per hour.

@Rossmaxx
Copy link
Author

So basically, i can just remove from the CI and it'll stop showing up?? Then why did i think of removing the option from the website first?

@tresf
Copy link
Member

tresf commented Nov 13, 2024

Then why did i think of removing the option from the website first?

Well, your PR also tells the user WHY they're missing, so your train of thought isn't wrong if enough people disagree this comment: #389 (comment).

Copy link
Member

@tresf tresf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic isn't hurting anyone and isn't the only combination that we don't build for.

lib/Artifacts.php Outdated Show resolved Hide resolved
lib/Artifacts.php Outdated Show resolved Hide resolved
@Rossmaxx Rossmaxx changed the title Remove 32 bit downloads for nightly Add warning for missing 32 bit downloads for nightly Dec 11, 2024
@Rossmaxx Rossmaxx requested a review from tresf December 11, 2024 10:17
templates/download/index.twig Outdated Show resolved Hide resolved
Co-authored-by: Tres Finocchiaro <[email protected]>
@tresf
Copy link
Member

tresf commented Dec 12, 2024

Ready for merge. This should be coordinated with the PR that actually removes them from CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants