-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning for missing 32 bit downloads for nightly #389
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
LMMS/lmms#7286 is the issue. |
Co-authored-by: FyiurAmron <[email protected]>
I think this PR is misdirected because it removes 32-bit builds from showing EVEN WHEN THEY'RE BUILT EVEN FOR PAST BUILDS. This doesn't really make sense. If we're to stop building 32-bit builds moving forward on the main repository, it'll save us CI time and they'll just stop appearing on our PRs and nightly pages. |
Probably GitHub rate limiting on your PC.
|
So basically, i can just remove from the CI and it'll stop showing up?? Then why did i think of removing the option from the website first? |
Well, your PR also tells the user WHY they're missing, so your train of thought isn't wrong if enough people disagree this comment: #389 (comment). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic isn't hurting anyone and isn't the only combination that we don't build for.
Co-authored-by: Tres Finocchiaro <[email protected]>
Ready for merge. This should be coordinated with the PR that actually removes them from CI. |
I've started to remove 32 bit support in the CI. If this gets through, nightlies won't have 32 bit artefacts anymore for windows. There should be a warning to explain the missing artifacts. Per LMMS/lmms#6614 (comment) by @tresf
TODO: