Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce variables for MPI compiler wrappers and document their usage #893

Merged
merged 5 commits into from
May 5, 2016

Conversation

davydden
Copy link
Member

@davydden davydden commented May 4, 2016

in the spirit of https://github.com/LLNL/spack/pull/657 .

tested with spack install p4est ^mpich and spack install p4est ^openmpi. Both compile fine.
p4est ^mpich have a few failed checks, but it is a separate issue not related to this PR.

@eschnett @alalazo @citibeth @lee218llnl @mathstuf @tgamblin ping.

fixes https://github.com/LLNL/spack/issues/572

@davydden
Copy link
Member Author

davydden commented May 4, 2016

@adamjstewart @mplegendre ping.

@adamjstewart
Copy link
Member

Don't forget mvapich2

@davydden
Copy link
Member Author

davydden commented May 4, 2016

Don't forget mvapich2

done.

@tgamblin
Copy link
Member

tgamblin commented May 5, 2016

@davydden: looks good to me -- can you move the mpicc, etc. variables to setup_dependent_package, though? The setup_dependent_environment function is supposed to be just for things that would need to go in modules. setup_dependent_package is supposed to be for spec- and python-module-level stuff.

@davydden
Copy link
Member Author

davydden commented May 5, 2016

@tgamblin done. I also removed module.mpicc from mpich::setup_dependent_package() as it is now superseeded by changes in this PR and

$ ag --py "\.mpicc"

did not reveal its usage in any package.

@tgamblin tgamblin merged commit 10b0cb1 into spack:develop May 5, 2016
xjrc added a commit to xjrc/spack that referenced this pull request May 9, 2016
xjrc added a commit to xjrc/spack that referenced this pull request May 26, 2016
@davydden davydden deleted the mpi_dependent_env branch May 28, 2017 20:57
olupton pushed a commit to olupton/spack that referenced this pull request Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

avoid hardcoding MPI compiler names in formulae
3 participants