Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Support nushell #25

Open
bzm3r opened this issue Jul 28, 2023 · 2 comments
Open

[FEAT]: Support nushell #25

bzm3r opened this issue Jul 28, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@bzm3r
Copy link

bzm3r commented Jul 28, 2023

Is your feature request related to a problem? Please describe.
I would like to use nushell along with whkd.

Describe the solution you'd like
Add nushell under supported terminals here:

pub enum Shell {

I can try to make a PR for this.

Describe alternatives you've considered
I have considered using PowerShell alongside nushell, but I had some trouble using both while keeping nushell as the "default". For now, I am going to disable nushell as the default shell (via COMSPEC).

Additional context
n/a

@bzm3r bzm3r added the enhancement New feature or request label Jul 28, 2023
@bzm3r
Copy link
Author

bzm3r commented Jul 29, 2023

So, I have a branch where I have something that is at least ready for testing: https://github.com/bzm3r/whkd/blob/master/src/main.rs#L145

Sadly, there is an issue on nushell's end that causes an error:

Error:   × Nushell launched as a REPL, but STDIN is not a TTY; either launch in a valid terminal or provide arguments to invoke a script!

@LGUG2Z
Copy link
Owner

LGUG2Z commented Jul 29, 2023

Very happy to have this added in once the issue in nutshell is resolved!

melMass added a commit to melMass/whkd that referenced this issue Feb 1, 2024
Mostly recreating the PR mentionned in:
LGUG2Z#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants