Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From_Corners Materials bug #381

Closed
benalexanderbonza opened this issue Nov 21, 2024 · 8 comments · Fixed by #388
Closed

From_Corners Materials bug #381

benalexanderbonza opened this issue Nov 21, 2024 · 8 comments · Fixed by #388
Assignees
Labels

Comments

@benalexanderbonza
Copy link

There seems to be an issue with using different material frequency-band coefficients for walls/ceiling/floors.

I get this error: "Error: All walls should have the same number of frequency bands"

When I use the same materials on shoebox rooms, it works, and if I just use different flat coefficients on the walls/ceiling/floor on the from_corners, it works.

(It also seems that if I use a sim_order larger than 3-4 on from_corners it doesn't run and my python environment stops responding - I don't know whether I'm using up all available memory? or whether this is linked to the previous bug)

@fakufaku
Copy link
Collaborator

fakufaku commented Dec 7, 2024

Thanks for reporting. I will investigate.

@fakufaku fakufaku self-assigned this Dec 7, 2024
@fakufaku
Copy link
Collaborator

fakufaku commented Dec 7, 2024

(It also seems that if I use a sim_order larger than 3-4 on from_corners it doesn't run and my python environment stops responding - I don't know whether I'm using up all available memory? or whether this is linked to the previous bug)

This is probably a limitation of the software. The image source model has exponential complexity for general rooms.
Moving to hybrid simulation by using ISM with max_order = 2 or 3 and using ray tracing for the rest may solve your problems.

@fakufaku fakufaku added the bug label Dec 7, 2024
@fakufaku
Copy link
Collaborator

fakufaku commented Dec 7, 2024

@benalexanderbonza I'd like to try to fix this bug. Could you please share a code snippet that illustrates what works with Shoebox, but fails with from_corners?

Thanks!

@fakufaku
Copy link
Collaborator

fakufaku commented Dec 7, 2024

BTW, are you by any chance using the combination of from_corners and extrude to make a 3D room?

In that case, I may know what the problem is.

fakufaku added a commit that referenced this issue Dec 7, 2024
…dled when using from_corners together with extrude. (issue #381)
fakufaku added a commit that referenced this issue Dec 7, 2024
@fakufaku fakufaku linked a pull request Dec 7, 2024 that will close this issue
5 tasks
@fakufaku
Copy link
Collaborator

fakufaku commented Dec 7, 2024

I could reproduce the issue. The problem is that extrude did not properly extend the number of bands of the materials to match that of the existing walls.

A fix is underway in PR #388 .

fakufaku added a commit that referenced this issue Dec 8, 2024
Fixes a bug where the single/multi-band materials is not properly handled when using from_corners together with extrude. (issue #381)
@fakufaku
Copy link
Collaborator

fakufaku commented Dec 8, 2024

The fix has been pushed to v0.8.3 if you'd like to give it a go.

@benalexanderbonza
Copy link
Author

That's great, thank you! All seems to be working with multiple bands now! Will try and implement a hybrid model with ray tracing too!

@benalexanderbonza
Copy link
Author

Unfortunately, I don't know if the hybrid model will work for my simulations as I'm modelling a spatial microphone so the diameter of the ray tracing receiver will have to be quite small, and therefore the number of rays would make the simulations very slow. Thank you for all your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants