Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plot of Microphones #355

Closed
jordanalwon opened this issue Jun 27, 2024 · 2 comments · Fixed by #387
Closed

Plot of Microphones #355

jordanalwon opened this issue Jun 27, 2024 · 2 comments · Fixed by #387
Assignees
@fakufaku
Labels
bug

Comments

@jordanalwon
Copy link

When I add multiple microphones or multiple microphone arrays, only one of them is displayed.
In line 1562 and 1775 of room.py, the iterator for the microphones should be self.mic_array.M and not self.mic_array.nmic.
@fakufaku fakufaku self-assigned this Jul 12, 2024
@fakufaku fakufaku added the bug label Jul 12, 2024
@fakufaku
Copy link
Collaborator

Thanks for reporting this. I will look into it.

fakufaku added a commit that referenced this issue Dec 7, 2024
@fakufaku
Fixes a few potential bugs with the MicrophoneArray class and adds so…
5dc0594 
…me tests. (issue #355)
@fakufaku fakufaku linked a pull request Dec 7, 2024 that will close this issue
Fixes a few potential bugs with the MicrophoneArray class and adds some tests. #387
Merged
5 tasks
@fakufaku
Copy link
Collaborator

fakufaku commented Dec 7, 2024

Finally looking at this. I noticed several holes in the MicrophoneArray class potentially leading to such bugs. I tried to plug them with PR #387 .
Please try again after the PR is merged and let me know if this fixes your problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fakufaku fakufaku

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes a few potential bugs with the MicrophoneArray class and adds some tests. LCAV/pyroomacoustics
2 participants
@fakufaku @jordanalwon