Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in pyroomacoustics/pyroomacoustics /beamforming.py #348

Closed
AVer-V003000 opened this issue May 24, 2024 · 1 comment
Closed

Error in pyroomacoustics/pyroomacoustics /beamforming.py #348

AVer-V003000 opened this issue May 24, 2024 · 1 comment

Comments

@AVer-V003000
Copy link

Hi,

I noticed that there might be an error in beamforming.py

at line 301:
R = circular_2D_array(center=center[:1], M=M, phi0=phi0, radius=radius)

I think center=center[:1] should be modified as center=center[:2], for a 2D array

Correct me if I'm wrong, thanks :))

fakufaku added a commit that referenced this issue May 26, 2024
fakufaku added a commit that referenced this issue May 26, 2024
* Fixes bug in circular_microphone_array_xyplane (#348). 

* Fixes frequency unit of room.plot_rir with kind=tf.
@fakufaku
Copy link
Collaborator

Thanks for finding this bug ❤️ I corrected it in PR #350.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants