Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary type conversions #244

Open
ilanDoron opened this issue Jun 26, 2018 · 0 comments
Open

unnecessary type conversions #244

ilanDoron opened this issue Jun 26, 2018 · 0 comments
Labels
Volume imbalance recorder contract

Comments

@ilanDoron
Copy link
Contributor

Unnecessary type conversions are introduced in the VolumeImbalance contract. In the addImbalance
function, the argument uint currentBlock is passed and again cast to uint a few lines later. The same
applies to the int buyAmount argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Volume imbalance recorder contract
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilanDoron