New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity rate contract should return 0 if rate was never set #168

Open

yaronvel opened this issue Mar 27, 2018 · 1 comment

Labels

Sanity Rate Contract

Contributor

yaronvel commented Mar 27, 2018

In present implementation it might revert.

yaronvel assigned ilanDoron

yaronvel added the mainnet contract label

Contributor

ilanDoron commented Mar 28, 2018

in which contract it might revert?
I does return 0 on this situation

ilanDoron removed the mainnet contract label

ilanDoron removed their assignment

Anyhowclick added the Sanity Rate Contract label

ayobuenavista mentioned this issue

Added maxGasPrice setting to SanityRates, and updated to solidity 6 #1053

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment