permanent flag is not avoiding computation of slug

[ivanseidel]

mongoose-slug-generator/lib/slug-generator.js

Lines 89 to 104 in 2429908

	} else {
	if (item.isShortIdMode) {
	makeUniqueShortIdSlug(doc, item.name, values, opts, function (err, slug) {
	if (!doc[item.name] || !(item.permanent && doc[item.name])) {
	doc[item.name] = slug;
	}
	callback();
	})
	} else {
	makeUniqueCounterSlug(doc, item.name, values, opts, item.padding , function (err, slug) {
	if (!doc[item.name] || !(item.permanent && doc[item.name])) {
	doc[item.name] = slug;
	}
	callback();
	})
	}

Method makeUniqueCounterSlug is being called before regardless of the necessity to re-create slug.

For instance:

• I have a document with an unique slug already set based on title
• The title changes and the doc gets saved
• The plugin will call makeUniqueCounterSlug (because the path has been modified)
• The plugin will check later if permanent flag is set and there is already an value set on it

It will not update the slug, although it did process the slug string and made a query on db.

Should this be avoided? if so, I can try to swap the order of the checking/generation and submit a merge request.

[YuriGor]

I fixed this in my fork by moving check of permanent flag up

[ivanseidel]

Here too @YuriGor: https://github.com/TendaDigital/mongoose-slug-generator

you can use yarn add @tenda.digital/mongoose-slug-generator