Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology command: open svg graph in the user’s preferred application #107

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Topology command: open svg graph in the user’s preferred application #107

merged 5 commits into from
Dec 20, 2024

Conversation

eguzki
Copy link
Collaborator

@eguzki eguzki commented Dec 19, 2024 •
edited
Loading

What

topology command: persist in local disk in DOT format and SVG format

❯ bin/kuadrantctl topology -h
Export and visualize kuadrant topology

Usage:
  kuadrantctl topology [flags]

Flags:
  -d, --dot string         Graphviz DOT output file
  -h, --help               help for topology
  -n, --namespace string   Topology's namespace (default "kuadrant-system")
  -o, --output string      SVG image output file

Global Flags:
  -v, --verbose   verbose output

Verification steps

  • Install kuadrant
helm repo add kuadrant https://kuadrant.io/helm-charts/ --force-update
helm install kuadrant kuadrant/kuadrant-operator --namespace kuadrant-system --create-namespace
  • Deploy kuadrant
kubectl -n kuadrant-system apply -f - <<EOF
apiVersion: kuadrant.io/v1beta1
kind: Kuadrant
metadata:
  name: kuadrant
spec: {}
EOF
  • Export and visualize topology

Compile the tool

make install

Run the command

bin/kuadrantctl topology -o ~/tmp/topology.svg

@eguzki eguzki linked an issue Dec 19, 2024 that may be closed by this pull request
Topology command: open default all to visualize SVG #106
Open
@eguzki eguzki changed the base branch from main to 103-topology-scaffolding-persisting-in-local-disk-the-existing-topology December 19, 2024 13:10
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 54.57%. Comparing base (fd21d07) to head (fc06185).

Files with missing lines Patch % Lines
cmd/topology.go 0.00% 35 Missing ⚠️
Additional details and impacted files 
@@                                             Coverage Diff                                             @@
##           103-topology-scaffolding-persisting-in-local-disk-the-existing-topology     #107      +/-   ##
===========================================================================================================
- Coverage                                                                    55.64%   54.57%   -1.07%     
===========================================================================================================
  Files                                                                           17       17              
  Lines                                                                          868      885      +17     
===========================================================================================================
  Hits                                                                           483      483              
- Misses                                                                         313      330      +17     
  Partials                                                                        72       72

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

trepel
trepel reviewed Dec 19, 2024
View reviewed changes
cmd/topology.go Outdated Show resolved Hide resolved
@trepel
Copy link

trepel commented Dec 20, 2024

LGTM

@trepel trepel merged commit 0018dfc into 103-topology-scaffolding-persisting-in-local-disk-the-existing-topology Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trepel trepel trepel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topology command: open default all to visualize SVG
3 participants
@eguzki @codecov-commenter @trepel