diff --git a/Makefile b/Makefile index 488a49d..0ca189f 100644 --- a/Makefile +++ b/Makefile @@ -57,16 +57,13 @@ install: fmt vet @set -e; \ GIT_SHA=$$(git rev-parse --short=7 HEAD 2>/dev/null) || { \ GIT_HASH=$${GITHUB_SHA:-NO_SHA}; \ - IS_DIRTY=false; \ }; \ if [ -z "$$GIT_HASH" ]; then \ GIT_DIRTY=$$(git diff --stat); \ if [ -n "$$GIT_DIRTY" ]; then \ GIT_HASH=$${GIT_SHA}-dirty; \ - IS_DIRTY=true; \ else \ GIT_HASH=$${GIT_SHA}; \ - IS_DIRTY=false; \ fi; \ fi; \ LDFLAGS="-X 'github.com/kuadrant/kuadrantctl/version.GitHash=$$GIT_HASH'"; \ diff --git a/README.md b/README.md index 7b2d3fa..e151e59 100644 --- a/README.md +++ b/README.md @@ -15,21 +15,15 @@ ### Compiling from Source -If you prefer to compile from source or are contributing to the project, you can install `kuadrantctl` using `go install` or `make install`. This method requires Golang 1.21 or newer. +If you prefer to compile from source or are contributing to the project, you can install `kuadrantctl` using `make install`. This method requires Golang 1.21 or newer. -```bash -go install github.com/kuadrant/kuadrantctl@latest -``` - -This command will compile `kuadrantctl` and install the binary executable in `$GOBIN` (defaulting to `$GOPATH/bin`). - -It is also possible to use the make target `install` to compile from source. From root of the repository, run +It is possible to use the make target `install` to compile from source. From root of the repository, run ```bash make install ``` -This will compile `kuadrantctl` and install it in the `bin` directory at root of directory. It will also ensure the correct version of the binary is displayed, rather than `v0.0.0` . It can be ran using `./bin/kuadrantctl` . +This will compile `kuadrantctl` and install it in the `bin` directory at root of directory. It will also ensure the correct version of the binary is displayed . It can be ran using `./bin/kuadrantctl` . ## Usage