-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sotw: rlp workflow #893
base: main
Are you sure you want to change the base?
sotw: rlp workflow #893
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #893 +/- ##
==========================================
- Coverage 81.49% 79.11% -2.39%
==========================================
Files 102 116 +14
Lines 7177 9809 +2632
==========================================
+ Hits 5849 7760 +1911
- Misses 898 1629 +731
+ Partials 430 420 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
leave the policy status to me, it is WIP in another branch |
0fe564a
to
125a5ff
Compare
125a5ff
to
4cef480
Compare
e2f7dc5
to
b5bd72f
Compare
Policy status belongs to this workflow. On you now. |
45f6211
to
bb71440
Compare
6436530
to
3408c68
Compare
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
… found Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
…en building the wasm action set name Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
…a policy may also affect the state of the resources status depends on) Signed-off-by: Guilherme Cassolato <[email protected]>
… from topology Signed-off-by: Guilherme Cassolato <[email protected]>
974f3b2
to
6fe893e
Compare
…formerly reported as 'no free routes to enforce policy') Signed-off-by: Guilherme Cassolato <[email protected]>
…is in the path to a route Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
…imit IDs and scopes Signed-off-by: Guilherme Cassolato <[email protected]>
… status condition Signed-off-by: Guilherme Cassolato <[email protected]>
…ition) Signed-off-by: Guilherme Cassolato <[email protected]>
6fe893e
to
b4bdabf
Compare
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
Signed-off-by: Guilherme Cassolato <[email protected]>
g.Expect(err).ToNot(HaveOccurred()) | ||
g.Expect(existingGateway.GetAnnotations()).To(HaveKeyWithValue(rlp.BackReferenceAnnotationName(), string(serialized))) | ||
Expect(lo.Filter(existingLimitador.Spec.Limits, func(l limitadorv1alpha1.RateLimit, _ int) bool { // a hack to isolate test namespaces sharing the same limitador cr | ||
return strings.HasPrefix(l.Namespace, fmt.Sprintf("%s/", testNamespace)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the right solution. Actually what we want is to no longer create one Kuadrant CR per test suite, but one single instance per cluster only, and write tests with that in mind.
State-of-the-world reconciler – RLP workflow
spec.targetRef.sectionName
spec.(defaults|overrides).strategy
Closes #821
Closes #477
Closes #475
Verification steps
Setup the environment:
(Until Kuadrant/wasm-shim#110 is merged) Patch the deployment to enable the new wasm-shim config structure:
kubectl set env -n kuadrant-system deployment/kuadrant-operator-controller-manager RELATED_IMAGE_WASMSHIM=quay.io/kuadrant/wasm-shim:config-revamp
Enable Envoy Gateway alongside with Istio:
Deploy an application:
(From now on and at anytime) Send requests to the application:
Deploy Kuadrant:
Create a gateway atomic default policy:
Create a route policy:
Modify the gateway policy to atomic override strategy:
Modify the gateway policy to merge override strategy:
Modify the route policy to define limits with the same name as limits defined by the gateway policy: