Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file should be added to allow for another way to run quickstart script without user prompt. #755

Closed
ehearneRedHat opened this issue Jul 11, 2024 · 3 comments
Labels
good first issue Good for newcomers kind/enhancement New feature or request

Comments

@ehearneRedHat
Copy link
Contributor

What:

A configuration file, to be stored as a json file and contains important variables/flags that hack/quickstart-setup.sh detects and runs the script without prompts .

How:

The configuration file could look like:

{
   "key": "value",
   "key1": "value1"
}

And can include important details such as running in single cluster or multi cluster mode, which DNS Provider (if any) wants to be used, followed by DNS Provider specific env vars, etc.

The script can check for a filename (maybe conf.json) within a set location, such as hack/, or the script can check for a passed in/set variable (maybe KUADRANT_CONF=<file>.json). When it detects that file, it can read in the variables from quiet mode mentioned in #743 so that both modes offer equivalent functionality .

This issue will need to be followed up by a docs write up explaining the new changes .

@pehala
Copy link
Contributor

pehala commented Jul 11, 2024

Why conf file? It feels needlesly complicated replacement for a proper CLI interface and ENV_VARS

@ehearneRedHat
Copy link
Contributor Author

It wouldn't replace the env vars, rather add more flexibility to our set up already. Take a look at the comments made by myself and @Boomatang here --> #744 (comment) . Let me know if you have other concerns about this.

@ehearneRedHat
Copy link
Contributor Author

closed as redundant

@ehearneRedHat ehearneRedHat closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2024
@github-project-automation github-project-automation bot moved this to Done in Kuadrant Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants