Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rlp-v2] Do not use gateway name nor host in the RL domain #201

Closed
guicassolato opened this issue Jun 15, 2023 · 0 comments
Closed

[rlp-v2] Do not use gateway name nor host in the RL domain #201

guicassolato opened this issue Jun 15, 2023 · 0 comments
Assignees

Comments

@guicassolato
Copy link
Contributor

Currently the RLP controller fills the namespace* attributes of the rate limit definitions, within a Limitador CR, with a string composed out of the Gateway namespaced name and hostname. Neither of those can be used to namespace the limits – and effectively the counters – or the following use cases cannot be addressed:

  • HTTPRoute or Gateway lists multiple hostnames → one shared counter for the multiple hostnames
  • HTTPRoute belongs to multiple Gateway parents → one shared counter for the multiple Gateway parents

* Named domain in the Envoy RateLimitRequest.

A suggestion is to use the namespaced name of the RateLimitPolicy instead.


Related to: Kuadrant/architecture#13, #156
Follows-up on: #199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants