You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With 🔥 the old conditions in Limitador, we need to translate the condition we use to identify which Limit to apply to the new "location" where the key is to be found, i.e. descriptors[0].<identifier> now rather than straight to <identifier> at the very least. We could also set the idor the name of the Limit to be that identifier and match against that: limit.id == descriptors[0]["limit.id"] and set the value of the limit.id descriptor entry to that identifier...
The same applies to every Limit's variables, they need to be looked up in descriptors[0]. rather then hoping for them to be set as root bindings.
Anything using limitador v2 will have to use this new way of configuring Limitador.
The text was updated successfully, but these errors were encountered:
I could be seeing this happening within the limitador-operator too... but it'd then also need to happen within the wasm-shim, for the variables that is... or if we decide to make what descriptor the data gets send (e.g. split it between different ones) then for the currently implied 0 index for descriptors[i] in conditions too; which I think would be wrong. Having the "translation" here is what would avoid code duplication and SRP being respected. But willing to hear otherwise...
With 🔥 the old conditions in Limitador, we need to translate the condition we use to identify which
Limit
to apply to the new "location" where the key is to be found, i.e.descriptors[0].<identifier>
now rather than straight to<identifier>
at the very least. We could also set theid
or the name of theLimit
to be that identifier and match against that:limit.id == descriptors[0]["limit.id"]
and set the value of thelimit.id
descriptor entry to that identifier...The same applies to every
Limit
'svariables
, they need to be looked up indescriptors[0].
rather then hoping for them to be set asroot
bindings.Anything using limitador v2 will have to use this new way of configuring Limitador.
The text was updated successfully, but these errors were encountered: