Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limitador v2: Translate RLP's predicates & counter variable to new data "path" #1079

Open
alexsnaps opened this issue Dec 12, 2024 · 1 comment

Comments

@alexsnaps
Copy link
Member

alexsnaps commented Dec 12, 2024

With 🔥 the old conditions in Limitador, we need to translate the condition we use to identify which Limit to apply to the new "location" where the key is to be found, i.e. descriptors[0].<identifier> now rather than straight to <identifier> at the very least. We could also set the idor the name of the Limit to be that identifier and match against that: limit.id == descriptors[0]["limit.id"] and set the value of the limit.id descriptor entry to that identifier...

The same applies to every Limit's variables, they need to be looked up in descriptors[0]. rather then hoping for them to be set as root bindings.

Anything using limitador v2 will have to use this new way of configuring Limitador.

@alexsnaps alexsnaps moved this to Todo in Kuadrant Dec 12, 2024
@alexsnaps
Copy link
Member Author

alexsnaps commented Dec 12, 2024

I could be seeing this happening within the limitador-operator too... but it'd then also need to happen within the wasm-shim, for the variables that is... or if we decide to make what descriptor the data gets send (e.g. split it between different ones) then for the currently implied 0 index for descriptors[i] in conditions too; which I think would be wrong. Having the "translation" here is what would avoid code duplication and SRP being respected. But willing to hear otherwise...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant