Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the RateLimitPolicy create form with changes to API for kuadrant v1 #68

Open
david-martin opened this issue Sep 13, 2024 · 3 comments
Labels

Comments

@david-martin
Copy link
Contributor

Depends on:

See conversation in slack at https://kubernetes.slack.com/archives/C05J0D0V525/p1726148541588629 for additional context.

This is a follow up to the changes in #63 (#31) where UI elements were held back to avoid redundant work.
An interim solution was used where an 'info' message is shown with text that directs the user to the yaml view if they want to set more complex limits configuration.

@maleck13
Copy link

setting as a must as it wont work without it

@R-Lawton
Copy link
Contributor

With the new change to remove the form for RLP and re evaluate how we want to show the complexity of the rlp this isn't needed for for 1.0

@jasonmadigan
Copy link
Member

yeah, think our late change to drop form editing of RLP's sort of anulls this for now. Will be something we'll have to tackle when we bring back a form view RLP (and AP) post 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

4 participants