Bug health checks fail to create if a hostname is used

[maleck13]

When a health check is reconciled, it will only work if an IP is used. This means when using an AWS loadbalancer no health check can be defined via DNSPolicy. When you define one, it will result in the following error

ERROR	Reconciler error	{"controller": "dnsrecord", "controllerGroup": "kuadrant.io", "controllerKind": "DNSRecord", "DNSRecord": {"name":"prod-web-api","namespace":"ingress-gateway"}, "namespace": "ingress-gateway", "name": "prod-web-api", "reconcileID": "ae615743-522f-4b3d-9ba9-a8e9d27621c8", "error": "InvalidInput: Invalid XML ; javax.xml.stream.XMLStreamException: org.xml.sax.SAXParseException; lineNumber: 1; columnNumber: 401; cvc-datatype-valid.1.2.3: 'ad17cad5895114caca43bdff1e676c2e-1588753257.eu-west-1.elb.amazonaws.com' is not a valid value of union type 'IPAddress'.\n\tstatus code: 400, request id: 6aff7834-14b5-4d55-b882-f693b1803ed8"}sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:329sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:266sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:227

This is because AWS expects an IP for a health check but we are attempting to create it using the host.

Options

• We should improve the error reporting on DNSRecord and propagate it back to the DNSPolicy
• Decide if we want to do a look up of the IP of a hostname and use that / those for the health check setup

[maleck13]

Closing as we intend to move away from this design #141