-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve DNSRecord deletion to better ensure changes are persisted #181
Labels
Milestone
Comments
While testing this a few test related issues came up: |
consider increasing deletion validation time / number of validation attempts as more owners are detected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
Update the dnsrecord deletion logic to better cover the situation where multiple writes could be happening to the same records.
We currently do a single validation loop after a delete that ensures that the expected result of a delete request is persisted, but this happens very quickly and it is possible, at scale, for other controllers to add back values after this validation attempt.
The logic needs to be changed here to allow longer and more validation attempts after a delete, especially when multiple owners are in play.
Note: This is only really observable when using AWS and with multiple DNSRecords, all contributing to a shared record set, are deleting at the same time.
Can be re-created by running the
test-e2e-multi
test suite on AWS:The text was updated successfully, but these errors were encountered: