Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthConfig v1beta2 stored in etcd #479

Closed
guicassolato opened this issue Aug 21, 2024 · 1 comment · Fixed by #482 or #483
Closed

AuthConfig v1beta2 stored in etcd #479

guicassolato opened this issue Aug 21, 2024 · 1 comment · Fixed by #482 or #483
Assignees
@alexsnaps
Labels
area/api
Milestone
v0.18.x

Comments

@guicassolato
Copy link
Collaborator

Change the stored version of the AuthConfig custom resources in etcd to v1beta2.
@guicassolato guicassolato added this to the v0.18.x milestone Aug 21, 2024
@guicassolato guicassolato moved this to Todo in Kuadrant Aug 21, 2024
@alexsnaps alexsnaps moved this from Todo to In Progress in Kuadrant Aug 26, 2024
@alexsnaps alexsnaps mentioned this issue Aug 26, 2024
Merged
@alexsnaps alexsnaps self-assigned this Aug 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Kuadrant Aug 27, 2024
@guicassolato
Copy link
Collaborator Author

I think this may have been inadvertently closed. As of today, the stored version of the AuthConfig in etcd is still v1beta1:

authorino/api/v1beta1/auth_config_types.go

Line 787 in d0a32df

// +kubebuilder:storageversion

authorino/install/crd/authorino.kuadrant.io_authconfigs.yaml

Line 2184 in d0a32df

storage: true

@guicassolato guicassolato reopened this Aug 28, 2024
@alexsnaps alexsnaps mentioned this issue Aug 28, 2024
Merged
@alexsnaps alexsnaps linked a pull request Aug 28, 2024 that will close this issue
Make v1beta2 the stored version #483
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexsnaps alexsnaps

Labels
area/api
Projects
Kuadrant
Status: Done
Milestone
v0.18.x
2 participants
@alexsnaps @guicassolato