From 87f77646b7bb95c601a467e26188f8d9e6f37841 Mon Sep 17 00:00:00 2001 From: Stefano Cappa Date: Fri, 31 May 2024 20:22:15 +0200 Subject: [PATCH] fix: small fixes to prepare 12.0.0 Signed-off-by: Stefano Cappa --- CONTRIBUTING.md | 35 ++++++++++--------- angular.json | 2 +- .../src/app/intro-header/intro-header.html | 4 +-- .../src/app/intro-header/intro-header.html | 4 +-- .../src/app/intro-header/intro-header.html | 4 +-- src/app/intro-header/intro-header.html | 4 +-- 6 files changed, 28 insertions(+), 25 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a9bfd4d2..fad9c0fb 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -25,40 +25,43 @@ Every time you'll run `npm install` inside an example's folder, you must rebuild # B. Run main example 1. `npm start` => if everything is ok (also in browser's console), kill the process and go to the next step 2. `npm run build:main:dev` -3. `cd dist/angular-modal-gallery && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step -4. `cd ../..` +3. `cd dist/angular-modal-gallery/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step +4. `cd ../../..` 5. `npm run build:main:prod` -6. `cd dist/angular-modal-gallery && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step -7. `cd ../..` +6. `cd dist/angular-modal-gallery/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step +7. `cd ../../../../..` # C. Run angular-cli-18 example 1. `cd examples/angular-cli-18` 2. `npm start` => if everything is ok (also in browser's console), kill the process and go to the next step 3. `npm run build:dev` -4. `cd dist/angular-cli && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step -5. `cd ../..` +4. `cd dist/angular-cli/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step +5. `cd ../../..` 6. `npm run build:prod` -7. `cd dist/angular-cli && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step -8. `cd ../..` +7. `cd dist/angular-cli/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step +8. `cd ../../../../..` # D. Run angular-cli-material example 1. `cd examples/angular-cli-material` 2. `npm start` => if everything is ok (also in browser's console), kill the process and go to the next step 3. `npm run build:dev` -4. `cd dist/angular-cli && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step -5. `cd ../..` +4. `cd dist/angular-cli/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step +5. `cd ../../..` 6. `npm run build:prod` -7. `cd dist/angular-cli && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step -8. `cd ../../../..` +7. `cd dist/angular-cli/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step +8. `cd ../../../../..` # E. Run universal example 1. `cd examples/universal` 2. `npm run start` => if everything is ok (also in browser's console), kill the process and go to the next step 3. `npm run build:dev` -4. `npm run serve:ssr` => if everything is ok (also in browser's console), kill the process and go to the next step -5. `npm run build:prod` -6. `npm run serve:ssr` => if everything is ok (also in browser's console), kill the process and go to the next step -7. `cd ../..` +4. `cd dist/universal/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step +5. `cd ../../..` +6. `npm run build:prod` +7. `cd dist/universal/browser && lite-server` => if everything is ok (also in browser's console), kill the process and go to the next step +8. `cd ../../..` +9. `npm run serve:ssr` => if everything is ok (also in browser's console), kill the process and go to the next step +10. `cd ../..` # H. Create your pull request 1. **If it is ok, create your pull request specifying all the details** diff --git a/angular.json b/angular.json index 24f8e2b4..3652fc38 100644 --- a/angular.json +++ b/angular.json @@ -24,7 +24,7 @@ "build": { "builder": "@angular-devkit/build-angular:application", "options": { - "outputPath": "dist/angular-cli", + "outputPath": "dist/angular-modal-gallery", "index": "src/index.html", "browser": "src/main.ts", "polyfills": [ diff --git a/examples/angular-cli-18/src/app/intro-header/intro-header.html b/examples/angular-cli-18/src/app/intro-header/intro-header.html index 629ed2ac..96f730b1 100644 --- a/examples/angular-cli-18/src/app/intro-header/intro-header.html +++ b/examples/angular-cli-18/src/app/intro-header/intro-header.html @@ -2,7 +2,7 @@ @ks89/angular-modal-gallery icon

@ks89/angular-modal-gallery

-

Image gallery for Angular >=16

-

Currently v11

+

Image gallery for Angular >=18

+

Currently v12


diff --git a/examples/angular-cli-material/src/app/intro-header/intro-header.html b/examples/angular-cli-material/src/app/intro-header/intro-header.html index 629ed2ac..96f730b1 100644 --- a/examples/angular-cli-material/src/app/intro-header/intro-header.html +++ b/examples/angular-cli-material/src/app/intro-header/intro-header.html @@ -2,7 +2,7 @@ @ks89/angular-modal-gallery icon

@ks89/angular-modal-gallery

-

Image gallery for Angular >=16

-

Currently v11

+

Image gallery for Angular >=18

+

Currently v12


diff --git a/examples/universal/src/app/intro-header/intro-header.html b/examples/universal/src/app/intro-header/intro-header.html index 629ed2ac..96f730b1 100644 --- a/examples/universal/src/app/intro-header/intro-header.html +++ b/examples/universal/src/app/intro-header/intro-header.html @@ -2,7 +2,7 @@ @ks89/angular-modal-gallery icon

@ks89/angular-modal-gallery

-

Image gallery for Angular >=16

-

Currently v11

+

Image gallery for Angular >=18

+

Currently v12


diff --git a/src/app/intro-header/intro-header.html b/src/app/intro-header/intro-header.html index 629ed2ac..96f730b1 100644 --- a/src/app/intro-header/intro-header.html +++ b/src/app/intro-header/intro-header.html @@ -2,7 +2,7 @@ @ks89/angular-modal-gallery icon

@ks89/angular-modal-gallery

-

Image gallery for Angular >=16

-

Currently v11

+

Image gallery for Angular >=18

+

Currently v12