Fix audio video #351
Merged
Fix audio video #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlaxcess
added
refacto
Open
zapaz
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix audio & video display
I set the context of "toPlayTokenID" in both Dapp.svelte & OpenSky.svelte components instead of Nfts.svelte to permit to stop the media when we open the zoom popup.
I purposely made two almost identical components for audio and video to make it easy to make one, but i didn't have enough time.
For this reason, there is css repetition in both components, because i choose to left those styles in this component, because it can't really be used anywhere else.
You can test on dapp in detail, zoom, grid or line mode & on Wordpress front with OpenSky shortcode for one or multiple Nfts. The comportement is different when you click on audio/video image in grid mode in dapp and when you click on audio/video image on opensky shortcode.
P.S : for a better experience, think to re-build styles... ;)