-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.9.0-RC: kotlinx-coroutines-core/concurrent/src/...
contains common (expect) and platform (actual) files
#4163
Comments
Could you link to some style guide that mandates this? I could not find this requirement anywhere. When I have deep hierarchies of source sets, I freely mix
Yeah, seems strange. The authors probably wanted |
An alternative solution is simply to remove the |
It's natural to establish some
Maybe that's some compiler bug. The stated reason for this error is to forbid implementing something in the same module where the
JS and Wasm have a separate implementation. |
I am running into this problem as well. My build system uses My build file looks something like:
The error:
I have tried moving various things around in the build file, but to no avail. Is it possible to build this using kotilnc 2.0.20 and a build.xml file? |
What broke?
Our current build setup globs all of
kotlinx-coroutines-core/common/src/...
andkotlinx-coroutines-core/concurrent/src/...
to pass as-Xcommon-srcs
. When we do this with-language-version=2.0
, which is stricter about expect/actual declarations, there's aEXPECT_AND_ACTUAL_IN_THE_SAME_MODULE
error forLockFreeLinkedListNode
.The problem is that there are some files from
kotlinx-coroutines-core/concurrent/src/...
that must be-Xcommon-srcs
(expects) and some that must not be (actuals). These files shouldn't be mixed together.Ideally, all expect files would be under a single root, such as
kotlinx-coroutines-core/common/src/...
.PS: What naming convention is
Builders.concurrent.kt
? It looks like someone wantedBuilders.common.kt
.Did I check that setting the version to the latest stable release fixes the problem?
Yes.
The text was updated successfully, but these errors were encountered: