Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable match expansion #150

Open
margaretha opened this issue Jun 12, 2024 · 1 comment
Open

Configurable match expansion #150

margaretha opened this issue Jun 12, 2024 · 1 comment

Comments

@margaretha
Copy link
Contributor

margaretha commented Jun 12, 2024

During the implementation of #144, we found an existing behavior relevant for the Corola instance, that match shouldn't be expanded (to sentences) when there is no sentence boundary, e.g. there is no sentence annotations in the data. Before #144, match expansion was restricted to match size only.

This behavior changes because match expansion now considers match context size. To keep the previous behavior, we can make match expansion configurable using krill properties by setting a property as follows.

krill.match.expansion.includeContextSize = true

where the default value is false.

idsgerrit pushed a commit that referenced this issue Jun 21, 2024
Change-Id: Ie4eb9098f6e7352918e1fd0d3bf74615d3508e7e
@Akron
Copy link
Member

Akron commented Oct 10, 2024

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants