New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review for LeaderboardServer.java #1

Open

glynkwei opened this issue Jul 7, 2017 · 0 comments

glynkwei commented Jul 7, 2017

https://github.com/Konnoke/Tetris/blob/master/src/tetris/LeaderboardServer.java#L15
https://github.com/Konnoke/Tetris/blob/master/src/tetris/LeaderboardServer.java#L16
https://github.com/Konnoke/Tetris/blob/master/src/tetris/LeaderboardServer.java#L30

Prefer interfaces over concrete collections (i.e. Lists and Set vs. ArrayList and HashSet)

https://github.com/Konnoke/Tetris/blob/master/src/tetris/LeaderboardServer.java#L18
More consistent naming scheme here?

https://github.com/Konnoke/Tetris/blob/master/src/tetris/LeaderboardServer.java#L44
Please remove

https://github.com/Konnoke/Tetris/blob/master/src/tetris/LeaderboardServer.java#L32
Do not throw Exception

https://github.com/Konnoke/Tetris/blob/master/src/tetris/LeaderboardServer.java#L77
Missing @OverRide annotation

https://github.com/Konnoke/Tetris/blob/master/src/tetris/LeaderboardServer.java#L84
https://github.com/Konnoke/Tetris/blob/master/src/tetris/LeaderboardServer.java#L98
AHHHHH

https://github.com/Konnoke/Tetris/blob/master/src/tetris/LeaderboardServer.java#L99
Should use while (in.readLine())

https://github.com/Konnoke/Tetris/blob/master/src/tetris/LeaderboardServer.java#L68
Add final when possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment