Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong params for proxy_on_vm_start #654

Open
dev-null-undefined opened this issue Dec 13, 2024 · 1 comment · May be fixed by #656
Open

Wrong params for proxy_on_vm_start #654

dev-null-undefined opened this issue Dec 13, 2024 · 1 comment · May be fixed by #656
Labels
area/proxy-wasm Area: Proxy-Wasm SDK bug Something isn't working

Comments

@dev-null-undefined
Copy link
Contributor

https://github.com/proxy-wasm/spec/blob/main/abi-versions/v0.2.1/README.md#proxy_on_vm_start

The proxy_wasm_spec specifies that the second argument for proxy_on_vm_start sould be the VM config size

Since from my knowladge of the code you do not support VM config yet, it would make sense to hard code 0 there with maybe a comment /* TODO VM configuration */

ngx_wasm_module/src/common/proxy_wasm/ngx_proxy_wasm.c

Line 1216 in 883b627

rexec->id, rexec->root_id);

@thibaultcha
Copy link
Member

Feel free to send a PR for this one as well. We do support VM configuration via our module directive.

@dev-null-undefined dev-null-undefined linked a pull request Dec 14, 2024 that will close this issue
Open
@thibaultcha thibaultcha added enhancement New feature or request area/proxy-wasm Area: Proxy-Wasm SDK bug Something isn't working and removed enhancement New feature or request labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/proxy-wasm Area: Proxy-Wasm SDK bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(proxy-wasm) pass hardcoded 0 as vm_configuration_size dev-null-undefined/ngx_wasm_module
2 participants
@thibaultcha @dev-null-undefined