Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong params for proxy_on_vm_start #654

Open
dev-null-undefined opened this issue Dec 13, 2024 · 1 comment · May be fixed by #656
Open

Wrong params for proxy_on_vm_start #654

dev-null-undefined opened this issue Dec 13, 2024 · 1 comment · May be fixed by #656
Labels
area/proxy-wasm Area: Proxy-Wasm SDK bug Something isn't working

Comments

@dev-null-undefined
Copy link
Contributor

https://github.com/proxy-wasm/spec/blob/main/abi-versions/v0.2.1/README.md#proxy_on_vm_start

The proxy_wasm_spec specifies that the second argument for proxy_on_vm_start sould be the VM config size

Since from my knowladge of the code you do not support VM config yet, it would make sense to hard code 0 there with maybe a comment /* TODO VM configuration */

rexec->id, rexec->root_id);

@thibaultcha
Copy link
Member

Feel free to send a PR for this one as well. We do support VM configuration via our module directive.

@thibaultcha thibaultcha added enhancement New feature or request area/proxy-wasm Area: Proxy-Wasm SDK bug Something isn't working and removed enhancement New feature or request labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy-wasm Area: Proxy-Wasm SDK bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants