From 07fc76d46c2bb27087f4175858be731838952c58 Mon Sep 17 00:00:00 2001 From: Thibault Charbonnier Date: Tue, 5 Dec 2023 08:47:07 -0800 Subject: [PATCH] chore(util) minor cleanup/improvements Remove `|| exit 0` so that `util/sdk.sh` exits with 1 on failures. --- util/sdk.sh | 3 ++- util/sdks/go.sh | 2 +- util/setup_dev.sh | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/util/sdk.sh b/util/sdk.sh index 9713041c0..caf123adf 100755 --- a/util/sdk.sh +++ b/util/sdk.sh @@ -44,7 +44,8 @@ Options: -V, --sdk-ver Proxy-Wasm SDK version to build (e.g. '0.2.1') - -f, --force, --clean Force a clean download or build. + -f, --force, --clean Force a clean build with --build, + or a clean download with --download. -h, --help Print this message and exit. diff --git a/util/sdks/go.sh b/util/sdks/go.sh index 3432e76c0..acb771ef9 100755 --- a/util/sdks/go.sh +++ b/util/sdks/go.sh @@ -105,7 +105,7 @@ EOF notice "compiling Go examples..." - make build.examples || exit 0 + make build.examples popd } diff --git a/util/setup_dev.sh b/util/setup_dev.sh index fe0f0742f..6918178bc 100755 --- a/util/setup_dev.sh +++ b/util/setup_dev.sh @@ -218,7 +218,7 @@ else notice "building proxy-wasm-go-sdk..." $NGX_WASM_DIR/util/sdk.sh -S go --build fi -# + # proxy-wasm-assemblyscript-sdk if [[ ! -x "$(command -v npm)" ]]; then