From d13b0349e23c6e8572ff710aa1a96cd430fcc930 Mon Sep 17 00:00:00 2001
From: Adam DeHaven <adam.dehaven@konghq.com>
Date: Fri, 22 Dec 2023 21:16:46 -0500
Subject: [PATCH] fix: split and preview modes

---
 src/components/MarkdownUi.vue              | 18 ++++++++++
 src/components/toolbar/InfoTooltip.vue     |  4 ++-
 src/components/toolbar/MarkdownToolbar.vue | 39 ++++++++++++++++++----
 3 files changed, 54 insertions(+), 7 deletions(-)

diff --git a/src/components/MarkdownUi.vue b/src/components/MarkdownUi.vue
index c302486d..128933b1 100644
--- a/src/components/MarkdownUi.vue
+++ b/src/components/MarkdownUi.vue
@@ -450,6 +450,24 @@ const markdownEditorMaxHeight = computed((): string => `${props.editorMaxHeight}
     }
   }
 
+  // Ensure split mode is never enabled below tablet
+  &.mode-edit {
+    .markdown-preview {
+      @media (max-width: ($kui-breakpoint-tablet - 1px)) {
+        display: none !important;
+      }
+    }
+  }
+
+  // Ensure split mode is never enabled below tablet
+  &.mode-preview {
+    .markdown-preview {
+      @media (max-width: ($kui-breakpoint-tablet - 1px)) {
+        display: flex !important;
+      }
+    }
+  }
+
   .markdown-editor,
   .markdown-preview {
     display: flex;
diff --git a/src/components/toolbar/InfoTooltip.vue b/src/components/toolbar/InfoTooltip.vue
index 582f0357..785f439b 100644
--- a/src/components/toolbar/InfoTooltip.vue
+++ b/src/components/toolbar/InfoTooltip.vue
@@ -33,7 +33,9 @@ defineProps({
   &:hover,
   &:focus-within {
     .tooltip-content {
-      opacity: 1;
+      @media (min-width: $kui-breakpoint-mobile) {
+        opacity: 1;
+      }
     }
   }
 }
diff --git a/src/components/toolbar/MarkdownToolbar.vue b/src/components/toolbar/MarkdownToolbar.vue
index a9218403..23115f43 100644
--- a/src/components/toolbar/MarkdownToolbar.vue
+++ b/src/components/toolbar/MarkdownToolbar.vue
@@ -17,6 +17,7 @@
           Edit
         </button>
         <button
+          class="mode-split-button"
           :class="{ 'active': mode === 'split' }"
           :tabindex="0"
           @click.prevent="changeMode('split')"
@@ -164,12 +165,12 @@
 </template>
 
 <script setup lang="ts">
-import { inject, ref, onMounted } from 'vue'
+import { inject, ref, onMounted, watch } from 'vue'
 import type { Ref } from 'vue'
 import { MODE_INJECTION_KEY, EDITABLE_INJECTION_KEY, FULLSCREEN_INJECTION_KEY, HTML_PREVIEW_INJECTION_KEY } from '@/injection-keys'
 import { useMediaQuery } from '@vueuse/core'
 import { TOOLBAR_HEIGHT } from '@/constants'
-import { KUI_BREAKPOINT_TABLET, KUI_ICON_SIZE_40 } from '@kong/design-tokens'
+import { KUI_BREAKPOINT_PHABLET, KUI_ICON_SIZE_40 } from '@kong/design-tokens'
 import type { MarkdownMode, FormatOption, TemplateOption, InlineFormat, MarkdownTemplate } from '@/types'
 import IconButton from '@/components/toolbar/IconButton.vue'
 import InfoTooltip from '@/components/toolbar/InfoTooltip.vue'
@@ -193,13 +194,26 @@ const emit = defineEmits<{
   (e: 'save'): void
 }>()
 
+// Determine if the user is on a wider viewport
+const isPhabletWidth = useMediaQuery(`(min-width: ${KUI_BREAKPOINT_PHABLET})`)
+
 const determineEditMode = (): void => {
-  // Determine if the user is on a wider viewport
-  const isWideScreen = useMediaQuery(`(min-width: ${KUI_BREAKPOINT_TABLET})`)
   // If yes, enter `split` mode, otherwise `edit` mode
-  changeMode(isWideScreen.value ? 'split' : 'edit')
+  changeMode(isPhabletWidth.value ? 'split' : 'edit')
+}
+
+// Verify the browser is wide enough to make `split` mode viable
+const adjustSplitMode = (): void => {
+  if (mode.value === 'split' && !isPhabletWidth.value) {
+    changeMode('edit')
+  }
 }
 
+// If the screen size decreases and the user is in `split` mode, turn on edit mode
+watch(isPhabletWidth, (): void => {
+  adjustSplitMode()
+})
+
 const changeMode = (newMode: MarkdownMode): void => {
   if (mode.value !== newMode) {
     emit('change-mode', newMode)
@@ -255,6 +269,9 @@ onMounted(() => {
   // Add a `mac` class to the container if on Mac (for shortcut icons)
   // @ts-ignore - property exists
   toolbar.value?.classList?.toggle('mac', /Mac|iPhone|iPod|iPad/i.test(navigator?.platform) || /macOS|Mac|iPhone|iPod|iPad/i.test(navigator?.userAgentData?.platform))
+
+  // If the screen size decreases and the user is in `split` mode, turn on edit mode
+  adjustSplitMode()
 })
 </script>
 
@@ -266,7 +283,9 @@ onMounted(() => {
   gap: var(--kui-space-70, $kui-space-70);
   height: v-bind('TOOLBAR_HEIGHT');
   justify-content: space-between;
-  // overflow-x: auto; // TODO: Handle overflow
+  // Allowing the toolbar to scroll horizontally will hide the keyboard shortcut tooltips
+  // which is fine on mobile since keyboard nav isn't as relevant there.
+  // overflow-x: auto; // TODO: Enable for horizontal scrolling
 
   // TODO: Replace with tabs
   .button-group {
@@ -294,6 +313,14 @@ onMounted(() => {
     }
   }
 
+  .mode-split-button {
+    display: none;
+
+    @media (min-width: $kui-breakpoint-phablet) {
+      display: inline-block;
+    }
+  }
+
   .toolbar-left,
   .toolbar-right {
     align-items: center;