Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce more standardised logging and error returning strategy #650

Open
1 of 3 tasks
programmer04 opened this issue May 10, 2023 · 0 comments
Open
1 of 3 tasks

Comments

@programmer04
Copy link
Member

programmer04 commented May 10, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Problem Statement

Currently, KTF for logging uses fmt.Printf. Furthermore, sometimes errors are returned and sometimes just logged, e.g., in function WaitForConnectionOnServicePort during EndpointSlices cleanup, instead of being returned to the caller with other errors.

Other projects (KGO and KIC) use

github.com/go-logr/logr
github.com/go-logr/zapr

hence KTF should use them too.

Proposed Solution

Introduce a more standardized way of dealing with such situations across the codebase.

Acceptance Criteria

  • standardized approach for logging
  • errors are rather returned to the caller instead of being logged by KTF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant