You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, KTF for logging uses fmt.Printf. Furthermore, sometimes errors are returned and sometimes just logged, e.g., in function WaitForConnectionOnServicePort during EndpointSlices cleanup, instead of being returned to the caller with other errors.
Other projects (KGO and KIC) use
github.com/go-logr/logr
github.com/go-logr/zapr
hence KTF should use them too.
Proposed Solution
Introduce a more standardized way of dealing with such situations across the codebase.
Acceptance Criteria
standardized approach for logging
errors are rather returned to the caller instead of being logged by KTF
The text was updated successfully, but these errors were encountered:
Is there an existing issue for this?
Problem Statement
Currently, KTF for logging uses
fmt.Printf
. Furthermore, sometimes errors are returned and sometimes just logged, e.g., in functionWaitForConnectionOnServicePort
duringEndpointSlices
cleanup, instead of being returned to the caller with other errors.Other projects (KGO and KIC) use
hence KTF should use them too.
Proposed Solution
Introduce a more standardized way of dealing with such situations across the codebase.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: