From 6b66e90564b01921eed8cfb1cb95fbffeb4f3d9b Mon Sep 17 00:00:00 2001 From: Mattia Lavacca Date: Fri, 26 Jul 2024 10:22:07 +0200 Subject: [PATCH] chore: leftover comment removed Signed-off-by: Mattia Lavacca --- api/configuration/v1alpha1/kongpluginbinding_types.go | 1 - .../crd/bases/configuration.konghq.com_kongpluginbindings.yaml | 2 -- docs/api-reference.md | 2 +- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/api/configuration/v1alpha1/kongpluginbinding_types.go b/api/configuration/v1alpha1/kongpluginbinding_types.go index ae3c451..c855dc8 100644 --- a/api/configuration/v1alpha1/kongpluginbinding_types.go +++ b/api/configuration/v1alpha1/kongpluginbinding_types.go @@ -93,7 +93,6 @@ type KongPluginBindingSpec struct { } type KongReferences struct { - // TODO(mlavacca): add validation that at least one of the following field is properly set. RouteReference *EntityRef `json:"routeRef,omitempty"` ServiceReference *EntityRef `json:"serviceRef,omitempty"` ConsumerReference *EntityRef `json:"consumerRef,omitempty"` diff --git a/config/crd/bases/configuration.konghq.com_kongpluginbindings.yaml b/config/crd/bases/configuration.konghq.com_kongpluginbindings.yaml index 482dac7..f5464e2 100644 --- a/config/crd/bases/configuration.konghq.com_kongpluginbindings.yaml +++ b/config/crd/bases/configuration.konghq.com_kongpluginbindings.yaml @@ -97,8 +97,6 @@ spec: - name type: object routeRef: - description: 'TODO(mlavacca): add validation that at least one - of the following field is properly set.' properties: name: description: Name is the name of the entity. diff --git a/docs/api-reference.md b/docs/api-reference.md index 48276c3..99ab4ec 100644 --- a/docs/api-reference.md +++ b/docs/api-reference.md @@ -648,7 +648,7 @@ _Appears in:_ | Field | Description | | --- | --- | -| `routeRef` _[EntityRef](#entityref)_ | TODO(mlavacca): add validation that at least one of the following field is properly set. | +| `routeRef` _[EntityRef](#entityref)_ | | | `serviceRef` _[EntityRef](#entityref)_ | | | `consumerRef` _[EntityRef](#entityref)_ | | | `consumerGroupRef` _[EntityRef](#entityref)_ | |