Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clustering/rpc): dao hooks of upsert/delete/update_by are missed #13819

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Oct 31, 2024

Summary

The dao hook does not handle upsert_by event thus PUT method requests are missed and not propagated to DPs.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-5734 and KAG-5551
Related ticket: KAG-5723

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Oct 31, 2024
@StarlightIbuki StarlightIbuki force-pushed the fix/rpc-v1-500 branch 3 times, most recently from 14c47ef to dcfc998 Compare October 31, 2024 09:46
@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 31, 2024
@chronolaw
Copy link
Contributor

Let's wait #13805 merged.

kong/clustering/rpc/manager.lua Show resolved Hide resolved
kong/clustering/services/sync/hooks.lua Outdated Show resolved Hide resolved
kong/clustering/services/sync/hooks.lua Outdated Show resolved Hide resolved
kong/clustering/services/sync/hooks.lua Outdated Show resolved Hide resolved
kong/clustering/services/sync/hooks.lua Show resolved Hide resolved
spec/02-integration/09-hybrid_mode/01-sync_spec.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw changed the title fix(rpc): dao hooks of *_by are missed fix(clustering/rpc): dao hooks of upsert/delete/update_by are missed Nov 4, 2024
@chronolaw
Copy link
Contributor

Should we set the target branch to master?

@StarlightIbuki StarlightIbuki marked this pull request as ready for review November 4, 2024 09:53
@team-eng-enablement team-eng-enablement removed the author/community PRs from the open-source community (not Kong Inc) label Nov 4, 2024
Base automatically changed from fix/rpc-v1-500 to master November 5, 2024 02:44
@ADD-SP ADD-SP merged commit a44e59d into master Nov 5, 2024
28 checks passed
@ADD-SP ADD-SP deleted the fix/sync-hook-bug branch November 5, 2024 06:23
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13819-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13819-to-master-to-upstream
git checkout -b cherry-pick-13819-to-master-to-upstream
ancref=$(git merge-base 6cb8235b72052173fb484d85475b65f193a85831 1c89c331aba960f882a76bbf07ee40529fdb227c)
git cherry-pick -x $ancref..1c89c331aba960f882a76bbf07ee40529fdb227c

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 5, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants