-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clustering/rpc): dao hooks of upsert/delete/update_by are missed #13819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Oct 31, 2024
StarlightIbuki
force-pushed
the
fix/rpc-v1-500
branch
3 times, most recently
from
October 31, 2024 09:46
14c47ef
to
dcfc998
Compare
StarlightIbuki
force-pushed
the
fix/sync-hook-bug
branch
from
October 31, 2024 09:48
cd7ac7c
to
76742b4
Compare
StarlightIbuki
force-pushed
the
fix/rpc-v1-500
branch
from
October 31, 2024 09:49
dcfc998
to
9b464bf
Compare
StarlightIbuki
force-pushed
the
fix/sync-hook-bug
branch
from
October 31, 2024 09:49
76742b4
to
776d837
Compare
team-gateway-bot
added
the
author/community
PRs from the open-source community (not Kong Inc)
label
Oct 31, 2024
StarlightIbuki
force-pushed
the
fix/rpc-v1-500
branch
from
November 4, 2024 03:06
9b464bf
to
5791783
Compare
StarlightIbuki
force-pushed
the
fix/sync-hook-bug
branch
from
November 4, 2024 03:06
776d837
to
9df5501
Compare
Let's wait #13805 merged. |
chronolaw
reviewed
Nov 4, 2024
chronolaw
changed the title
fix(rpc): dao hooks of *_by are missed
fix(clustering/rpc): dao hooks of upsert/delete/update_by are missed
Nov 4, 2024
Should we set the target branch to |
StarlightIbuki
commented
Nov 4, 2024
chronolaw
reviewed
Nov 4, 2024
team-eng-enablement
removed
the
author/community
PRs from the open-source community (not Kong Inc)
label
Nov 4, 2024
add hook dao:*_by:fail Co-authored-by: Chrono <[email protected]>
StarlightIbuki
force-pushed
the
fix/sync-hook-bug
branch
from
November 5, 2024 02:48
879a5ec
to
46e3bc9
Compare
chobits
reviewed
Nov 5, 2024
chronolaw
reviewed
Nov 5, 2024
chronolaw
approved these changes
Nov 5, 2024
chobits
approved these changes
Nov 5, 2024
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13819-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13819-to-master-to-upstream
git checkout -b cherry-pick-13819-to-master-to-upstream
ancref=$(git merge-base 6cb8235b72052173fb484d85475b65f193a85831 1c89c331aba960f882a76bbf07ee40529fdb227c)
git cherry-pick -x $ancref..1c89c331aba960f882a76bbf07ee40529fdb227c |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Nov 5, 2024
kikito
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
core/clustering
core/db
schema-change-noteworthy
size/M
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The dao hook does not handle
upsert_by
event thusPUT
method requests are missed and not propagated to DPs.Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5734 and KAG-5551
Related ticket: KAG-5723