fix(build): snappy on macos was failing to build because of wrong extension #12928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension Signed-off-by: Aapo Talvensaari <[email protected]>
github-actions
bot
added
build/bazel
cherry-pick kong-ee
fffonion
approved these changes
Apr 24, 2024
|
Damn, it does not seem to be enough to fix it. Looking further. |
github-actions
bot
added
the
chore
Water-Melon
force-pushed
the
fix/mac-os-snappy
branch
from
e67db1b to
cd3e086
Compare
Water-Melon
force-pushed
the
fix/mac-os-snappy
branch
from
cd3e086 to
f828fc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Snappy on MacOS (
make build-venvwas failing).