feat(core): add /schemas/vaults/:name endpoint
#11727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Schmid <[email protected]>
jschmid1
force-pushed
the
feat/vault-schema-endpoint
branch
from
0f8b75b to
ea147e2
Compare
gszr
approved these changes
Oct 10, 2023
jschmid1
commented
Oct 10, 2023
Co-authored-by: Joshua Schmid <[email protected]>
hanshuebner
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding a new endpoint for named vaults.
/schemas/vaults/:nameVaults are very similar to plugins in terms of internal structure and we do provide such an endpoint for plugins already (
/schemas/plugins/:name). This endpoint allows us to query a schema of a specific vault, which wasn't possible before.@Guaris @fabianrbz This might be of interest to you.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix https://konghq.atlassian.net/browse/KAG-2535