refactor(tools): separate table related functions from utils #11723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
changed the title
chronolaw
force-pushed
the
refactor/separate_table_funcs_from_utils
branch
from
1de0cd7 to
ffdcfc4
Compare
Water-Melon
reviewed
Oct 18, 2023
| -- *** NOTE *** string-keys containing integers are considered valid array entries! | ||
| -- @param t The table to check | ||
| -- @return Returns `true` if the table is an array, `false` otherwise | ||
| function _M.is_lapis_array(t) |
There was a problem hiding this comment.
I don't know why the original code has two same functions
There was a problem hiding this comment.
I have the same feeling with you, but this PR is refactoring, won't change anything.
After this PR, we could check the code carefully.
Water-Melon
approved these changes
Oct 18, 2023
chronolaw
force-pushed
the
refactor/separate_table_funcs_from_utils
branch
from
ffdcfc4 to
540afc0
Compare
chobits
approved these changes
Oct 24, 2023
chronolaw
force-pushed
the
refactor/separate_table_funcs_from_utils
branch
from
540afc0 to
03e0f39
Compare
tzssangglass
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a try to refactor the big
tools.utils.lua, now it moves the functions of table into a separated module.KAG-2739
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
Issue reference
Fix #[issue number]