Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template): fix failure of starting if proxy_access_log is off #11712

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(template): fix failure of starting if proxy_access_log is off #11712

merged 1 commit into from
Oct 9, 2023

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Oct 9, 2023 •
edited
Loading

Summary

Kong can't start once we set proxy_access_log to off as access_log off kong_log_format is invalid in Nginx.

Checklist

  • The Pull Request has tests
  • [N/A] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-2730

@ADD-SP ADD-SP marked this pull request as ready for review October 9, 2023 05:35
@ADD-SP ADD-SP requested a review from samugi October 9, 2023 05:35
@samugi samugi merged commit 6b3d3c5 into master Oct 9, 2023
34 of 36 checks passed
@samugi samugi deleted the add_sp/fix-access-log branch October 9, 2023 07:09
@ADD-SP ADD-SP added this to the 3.5.0 milestone Oct 9, 2023
@team-gateway-bot team-gateway-bot mentioned this pull request Nov 21, 2023
Merged
@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/2.8.x:

@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/2.8.x with exitcode 1

@team-gateway-bot team-gateway-bot mentioned this pull request Nov 21, 2023
Merged
@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.4.x with exitcode 1

@team-gateway-bot
Copy link
Collaborator

Successfully created backport PR for release/3.4.x:

@outsinre outsinre mentioned this pull request Nov 22, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samugi samugi samugi approved these changes

Assignees

@ADD-SP ADD-SP

Labels
core/cli core/templates size/S skip-changelog
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ADD-SP @team-gateway-bot @samugi