Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clustering/rpc): generate rpc disconnected event #14077

Merged
merged 2 commits into from
Jan 7, 2025
Merged

feat(clustering/rpc): generate rpc disconnected event #14077

merged 2 commits into from
Jan 7, 2025

Conversation

chronolaw
Copy link
Contributor

Summary

KAG-5891

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/clustering cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jan 2, 2025
@chronolaw chronolaw force-pushed the feat/rpc_disconnect_event branch from 750fa12 to a14aec8 Compare January 3, 2025 08:20
@chronolaw chronolaw marked this pull request as ready for review January 3, 2025 08:22
@ADD-SP ADD-SP added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Jan 6, 2025
@chronolaw chronolaw force-pushed the feat/rpc_disconnect_event branch from 208345f to d90ef35 Compare January 6, 2025 06:49
StarlightIbuki
StarlightIbuki reviewed Jan 6, 2025
View reviewed changes
Copy link
Contributor

@StarlightIbuki StarlightIbuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refer to #14054
at least I want it to update the connection status of the DP

@chronolaw
Copy link
Contributor Author

please refer to #14054 at least I want it to update the connection status of the DP

As discussed offline, we could add this feature later.

@ADD-SP ADD-SP merged commit df6cc59 into master Jan 7, 2025
25 checks passed
@ADD-SP ADD-SP deleted the feat/rpc_disconnect_event branch January 7, 2025 02:28
@AndyZhang0707 AndyZhang0707 mentioned this pull request Jan 9, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarlightIbuki StarlightIbuki StarlightIbuki left review comments

@Water-Melon Water-Melon Water-Melon approved these changes

@chobits chobits chobits approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/clustering incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @chobits @Water-Melon @StarlightIbuki @ADD-SP