Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ai-proxy): fix red test due to other feature break http protocol behavior #13848

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

oowl
Copy link
Member

@oowl oowl commented Nov 7, 2024

Summary

In 7d71b6b, we introduce disable http2 alpn in ai-proxy plugin, now all http2 force protocol test will failed, so do not need http2 test in ai-proxy anymore, because we have been disabled http2.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix AG-119

@oowl oowl changed the title test(ai-proxy): fix red test due to other feature break http protocol… test(ai-proxy): fix red test due to other feature break http protocol behavior Nov 7, 2024
@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 7, 2024
@flrgh flrgh merged commit e3b5220 into master Nov 7, 2024
37 checks passed
@flrgh flrgh deleted the fix-ai-proxy-test branch November 7, 2024 20:30
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13848-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13848-to-master-to-upstream
git checkout -b cherry-pick-13848-to-master-to-upstream
ancref=$(git merge-base 713908f565f80ad83a57ac304114252d7e05c3d6 d0d5d6b73a2c53dbde1c59c590c10e6122c31c33)
git cherry-pick -x $ancref..d0d5d6b73a2c53dbde1c59c590c10e6122c31c33

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 7, 2024
@oowl oowl removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants