refactor(pdk): show more friendly error msg when passing invalid arguments #13224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/pdk
cherry-pick kong-ee
ADD-SP
changed the title
store_response_header should accept nil as arg#3store_response_header should accept nil for value
ADD-SP
force-pushed
the
add_sp/fix-rl-pdk
branch
from
f77ad1e to
2c50a62
Compare
ADD-SP
changed the title
store_response_header should accept nil for value
ADD-SP
changed the title
StarlightIbuki
approved these changes
Jun 18, 2024
Water-Melon
approved these changes
Jun 18, 2024
ADD-SP
added
incomplete-cherry-pick
|
Manually cherry-picked to https://github.com/Kong/kong-ee/pull/9478. |
ADD-SP
removed
the
incomplete-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The function
assertdoesn't show the caller of the PDK function when failed to validate incoming arguments. Invoking functionerrorwhen unable to validate an argument can get a better error message.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-4679