fix(ai-proxy): do not double-gzip responses when status is not 200 #12493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysoekong
added
cherry-pick kong-ee
locao
changed the title
|
Skipping changelog as this is a fix for an unreleased feature. |
curiositycasualty
approved these changes
Feb 1, 2024
tysoekong
force-pushed
the
fix/ai_proxy_double_gzip
branch
from
1ade18a to
260510d
Compare
gruceo
approved these changes
Feb 1, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
(cherry picked from commit 1fb8be5)
3 tasks
|
Successfully created backport PR for |
curiositycasualty
pushed a commit
that referenced
this pull request
Feb 1, 2024
…) (#12496) (cherry picked from commit 1fb8be5) Co-authored-by: Jack Tysoe <[email protected]>
gruceo
added
cherry-pick kong-ee
|
Successfully created cherry-pick PR for |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/3.6.x
git worktree add -d .worktree/backport-12493-to-release/3.6.x origin/release/3.6.x
cd .worktree/backport-12493-to-release/3.6.x
git switch --create backport-12493-to-release/3.6.x
git cherry-pick -x 1fb8be5a52c0adfeceae89e2056128734ccfc489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Logic error - with non-200 responses from the LLM, I was double-gzip'ing the response messages (if there was
content-encoding: gzipheader present).This is a quick fix for it before 3.6.0 release, and this whole response phase can be refactored during the tech preview phase.
Checklist
changelog/unreleased/kongN/A - part of new feature in 3.6.0, there is "no existing changelog" yetIssue reference
Bug discovery during field testing.