Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL plugin ignores configured header type for incoming requests #12215

Closed
1 task done
aetimmes opened this issue Dec 15, 2023 · 3 comments · Fixed by #12670
Closed
1 task done

OTEL plugin ignores configured header type for incoming requests #12215

aetimmes opened this issue Dec 15, 2023 · 3 comments · Fixed by #12670

Comments

@aetimmes
Copy link

aetimmes commented Dec 15, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Kong version ($ kong version)

Kong 3.5.0.0-ent

Current Behavior

The opentelemetry plugin ignores the configured header preference on incoming requests and emits warning logs whenever a request with mismatching headers is received.

Expected Behavior

The plugin should only ingest trace headers of the configured type and silently ignore incoming request headers of all other trace types.

Steps To Reproduce

Configure the opentelemetry plugin with a specific type (eg header_type: datadog).

Anything else?

No response

@ADD-SP
Copy link
Contributor

ADD-SP commented Dec 18, 2023

Thanks @aetimmes, this issue is already tracked internally (KAG-3568).

@chronolaw
Copy link
Contributor

@ADD-SP, could you add the ticket number here? thanks.

@samugi samugi linked a pull request Mar 25, 2024 that will close this issue
3 tasks
@samugi
Copy link
Member

samugi commented Mar 25, 2024

this is now supported with #12670

@samugi samugi closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants