Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel build fails due to an error fetching kong_admin_gui #11555

Closed
1 task done
theMiddleBlue opened this issue Sep 12, 2023 · 7 comments
Closed
1 task done

bazel build fails due to an error fetching kong_admin_gui #11555

theMiddleBlue opened this issue Sep 12, 2023 · 7 comments
Assignees

Comments

@theMiddleBlue
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Kong version ($ kong version)

3.4.0.0

Current Behavior

during the bazel build I got this error:

ERROR: An error occurred during the fetch of repository 'kong_admin_gui':
   Traceback (most recent call last):
	File "/usr/local/src/kong/build/repositories.bzl", line 105, column 13, in _github_release_impl
		fail("Failed to download release (%s): %s, exit: %d" % (gh_token_set, ret.stderr, ret.return_code))
Error in fail: Failed to download release (GITHUB_TOKEN is not set, is this a private repo?): To get started with GitHub CLI, please run:  gh auth login
Alternatively, populate the GH_TOKEN environment variable with a GitHub API authentication token.

Expected Behavior

No response

Steps To Reproduce

No response

Anything else?

No response

@chronolaw
Copy link
Contributor

I think that you need a github token to access these repo, try to generate a token, then

export GITHUB_TOKEN=xxx
make build-venv

@chronolaw chronolaw added the pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc... label Sep 14, 2023
@chronolaw
Copy link
Contributor

Perhaps you could find something useful. https://github.com/Kong/kong/blob/master/DEVELOPER.md

@woodensquares
Copy link

it seems the build now depends on the Github CLI to download dependencies, which is the one requiring the token. There is an open issue cli/cli#2680 about allowing gh release download to work without one, but it's been open for a while. To allow for kong builds in CI/CD it would be great if the dependency on gh cli was removed and instead a script with curl etc. was used to download the various release sources.

@chronolaw chronolaw removed the pending author feedback Waiting for the issue author to get back to a maintainer with findings, more details, etc... label Sep 16, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

This issue is marked as stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Oct 5, 2023
@jeremyjpj0916
Copy link
Contributor

jeremyjpj0916 commented Oct 25, 2023

it seems the build now depends on the Github CLI to download dependencies, which is the one requiring the token. There is an open issue cli/cli#2680 about allowing gh release download to work without one, but it's been open for a while. To allow for kong builds in CI/CD it would be great if the dependency on gh cli was removed and instead a script with curl etc. was used to download the various release sources.

Kong had said they were gonna update docs to mention the extra dependencies. Agree needing to setup a github token for the build is a bit annoying when you can't just clone down and execute ootb. Environment pre-prep needed atm.

EDIT - Ah they did update docs to note it. Good to see.

@hanshuebner
Copy link
Contributor

The documentation was updated, closing

@imjasonh
Copy link

imjasonh commented Jan 3, 2025

To allow for kong builds in CI/CD it would be great if the dependency on gh cli was removed and instead a script with curl etc. was used to download the various release sources.

This seems fairly straightforward to support (famous last words...)

If I were interested in sending a PR to fetch releases with a script using curl, would this be considered acceptable? I don't want to waste my time if there's a reason gh releases download was preferred over the simpler (auth-free) solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants