From 014f55421cb4e14f45f961034fa5475f00b0459e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hans=20H=C3=BCbner?= Date: Thu, 25 Jan 2024 16:53:24 +0100 Subject: [PATCH] chore(ci): revert upload/download-artifact version bump to v4 The v4 version causes issues in EE, so we decided to stay on v3 for now. Reverts 9cf81aba64 --- .github/workflows/build.yml | 2 +- .github/workflows/build_and_test.yml | 14 +++++++------- .github/workflows/perf.yml | 6 +++--- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3e5572b0f33..88704ccdedc 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -73,7 +73,7 @@ jobs: luarocks config - name: Bazel Outputs - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 if: failure() with: name: bazel-outputs diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml index 812e69b7c0f..9ad8a072ebb 100644 --- a/.github/workflows/build_and_test.yml +++ b/.github/workflows/build_and_test.yml @@ -113,7 +113,7 @@ jobs: $TEST_CMD - name: Archive coverage stats file - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 if: ${{ always() && (inputs.coverage == true || github.event_name == 'schedule') }} with: name: luacov-stats-out-${{ github.job }}-${{ github.run_id }} @@ -251,7 +251,7 @@ jobs: - name: Download test rerun information - uses: actions/download-artifact@v4 + uses: actions/download-artifact@v3 continue-on-error: true with: name: ${{ env.FAILED_TEST_FILES_FILE }} @@ -273,14 +273,14 @@ jobs: - name: Upload test rerun information if: always() - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 with: name: ${{ env.FAILED_TEST_FILES_FILE }} path: ${{ env.FAILED_TEST_FILES_FILE }} retention-days: 2 - name: Archive coverage stats file - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 if: ${{ always() && (inputs.coverage == true || github.event_name == 'schedule') }} with: name: luacov-stats-out-${{ github.job }}-${{ github.run_id }}-${{ matrix.suite }}-${{ contains(matrix.split, 'first') && '1' || '2' }} @@ -360,7 +360,7 @@ jobs: .ci/run_tests.sh - name: Archive coverage stats file - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 if: ${{ always() && (inputs.coverage == true || github.event_name == 'schedule') }} with: name: luacov-stats-out-${{ github.job }}-${{ github.run_id }} @@ -419,7 +419,7 @@ jobs: .ci/run_tests.sh - name: Archive coverage stats file - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 if: ${{ always() && (inputs.coverage == true || github.event_name == 'schedule') }} with: name: luacov-stats-out-${{ github.job }}-${{ github.run_id }} @@ -449,7 +449,7 @@ jobs: sudo luarocks install luafilesystem # Download all archived coverage stats files - - uses: actions/download-artifact@v4 + - uses: actions/download-artifact@v3 - name: Stats aggregation shell: bash diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml index 337111269bf..d71b8851903 100644 --- a/.github/workflows/perf.yml +++ b/.github/workflows/perf.yml @@ -65,7 +65,7 @@ jobs: luarocks - name: Bazel Outputs - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 if: failure() with: name: bazel-outputs @@ -267,7 +267,7 @@ jobs: done - name: Save results - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 if: always() with: name: perf-results @@ -278,7 +278,7 @@ jobs: retention-days: 31 - name: Save error logs - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 if: always() with: name: error_logs