Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many CI failures; cache generated images #126

Closed
Tieske opened this issue Nov 20, 2020 · 2 comments
Closed

Too many CI failures; cache generated images #126

Tieske opened this issue Nov 20, 2020 · 2 comments

Comments

@Tieske
Copy link
Member

Tieske commented Nov 20, 2020

Most of the CI failures (false negatives) are errors while building the test image;

  • Pulling the Enterprise images from Bintray (95%)
  • downloading packages during the build (5%)

If the generated images were cached, we could circumvent that, and also reduce the docker pulls. (possibly even speed up the tests)

Issues:

  1. Caching is done based on test-matrix usually: since the Pongo version is not in the test matrix (Pongo is unversioned), we might end up running Pongo against an image build by an older version of Pongo.
  2. common test matrix is running a single version, and hence a single image, how about multiple images?
  3. How to make sure it works with multiple CI engines

Proposal:

  • to cater for 1 above; pongo generates a cache file-name based of; a) it's own commit-id, b) standard named extension
  • pongo load <dir>: if the filename exists in the cache-directory, the file is loaded (docker load?)
  • pongo save <dir>: exports all pongo images to the file (docker save?)
  • when saving, any other file in that dir with the pongo filename extension gets deleted (it would mean generated by a different Pongo version/commit-id), and since that is not covered by the CI matrix, Pongo should take care of this clean up
@Tieske
Copy link
Member Author

Tieske commented Nov 20, 2020

Important: only Kong versioned images should be saved, nightly or other "moving" targets should never be written to the cache file

@Tieske
Copy link
Member Author

Tieske commented Jul 21, 2022

to be fixed by #220

@Tieske Tieske closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant