From e7868a9d7a5b3523983d6d82840b6f1bcd48bb44 Mon Sep 17 00:00:00 2001 From: Maksym Portianoi Date: Thu, 7 Nov 2024 12:54:17 -0500 Subject: [PATCH] fix: update notification icon (#437) --- .github/workflows/publish.yaml | 2 +- README.md | 6 +++--- .../__snapshots__/generate-icon-components.spec.ts.snap | 1 + src/tests/__snapshots__/NotificationIcon.html | 2 +- svg/solid/notification.svg | 2 +- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index c7931105..158ca3c7 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -59,7 +59,7 @@ jobs: # against for future runs. Since the snapshot files are modified here in the CI, they are written back # to the repository via the `/package.json` file `@semantic-release/git` => `assets` config - name: Update test snapshots - run: pnpm test -u + run: pnpm test -- --update - name: Semantic Release uses: cycjimmy/semantic-release-action@v4 diff --git a/README.md b/README.md index 7695605d..1db4fc1d 100644 --- a/README.md +++ b/README.md @@ -142,7 +142,7 @@ To add a new SVG: 2. Ensure the filename is lowercase and kebab-case 3. Place the SVG file into the corresponding `/svg/*` subdirectory. 4. Locally, run `pnpm generate` to create the corresponding Vue component -5. Locally, run `pnpm test -- -u` to run the tests and update the test snapshots +5. Locally, run `pnpm test -- --update` to run the tests and update the test snapshots 6. [Commit your changes](#committing-changes) and push up a Pull Request for review ### Development Sandbox @@ -193,10 +193,10 @@ pnpm test pnpm test:open # Update test snapshots -pnpm test -u +pnpm test -- --update ``` -When SVG files are added or removed, this will cause the test(s) that compare snapshots to fail. If the snapshot change is expected, run `pnpm test -u` to update the test snapshots accordingly, then commit those changes to your branch. +When SVG files are added or removed, this will cause the test(s) that compare snapshots to fail. If the snapshot change is expected, run `pnpm test -- --update` to update the test snapshots accordingly, then commit those changes to your branch. ### Build for production diff --git a/scripts/utilities/__snapshots__/generate-icon-components.spec.ts.snap b/scripts/utilities/__snapshots__/generate-icon-components.spec.ts.snap index 6bf3b09e..788d658a 100644 --- a/scripts/utilities/__snapshots__/generate-icon-components.spec.ts.snap +++ b/scripts/utilities/__snapshots__/generate-icon-components.spec.ts.snap @@ -714,6 +714,7 @@ exports[`generate > does not remove icons from the previous build 1`] = ` "FlagZwIcon.vue", "ForwardIcon.vue", "GatewayIcon.vue", + "GithubIcon.vue", "GoogleCloudIcon.vue", "GoogleIcon.vue", "GraduationIcon.vue", diff --git a/src/tests/__snapshots__/NotificationIcon.html b/src/tests/__snapshots__/NotificationIcon.html index 6f8c77ab..fd85f4d2 100644 --- a/src/tests/__snapshots__/NotificationIcon.html +++ b/src/tests/__snapshots__/NotificationIcon.html @@ -1 +1 @@ -My custom title \ No newline at end of file +My custom title \ No newline at end of file diff --git a/svg/solid/notification.svg b/svg/solid/notification.svg index a9ae4485..a2506aa6 100644 --- a/svg/solid/notification.svg +++ b/svg/solid/notification.svg @@ -1,3 +1,3 @@ - +