Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Reuse Connection #152

Open
AntoineJac opened this issue Dec 5, 2024 · 0 comments
Open

Feature - Reuse Connection #152

AntoineJac opened this issue Dec 5, 2024 · 0 comments
Assignees

Comments

@AntoineJac
Copy link
Collaborator

In the code we are using default value for KeepAlive meaning the connection will stay opened for 60s except if use setting --headers "Connection: close".

I think we should configure the Http Transport config MaxIdleConns, MaxIdleConnsPerHost, IdleConnTimeout in the file:
https://github.com/Kong/go-database-reconciler/blob/main/pkg/utils/types.go

For instance:
transport := &http.Transport{ IdleConnTimeout: 30 * time.Second, // Custom idle timeout MaxIdleConns: 10, // Max idle connections MaxIdleConnsPerHost: 5, // Max idle connections per host }

I think they fields should be configurable as cmd line parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants