Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIC review and document plugin protocols behavior #8280

Open
rainest opened this issue May 12, 2021 · 0 comments
Open

KIC review and document plugin protocols behavior #8280

rainest opened this issue May 12, 2021 · 0 comments
Labels
team-k8s Kubernetes task tracking (including KIC,KGO)

Comments

@rainest
Copy link
Contributor

rainest commented May 12, 2021

Originally raised internally in FTI-2517.

Kong plugins support a protocols field indicating which request protocols (e.g. http, grpc) they run on. KongPlugin resources have supported this field for a while (since 0.4), but we do not mention it in documentation.

The Kong and KIC defaults also diverged at some point. Kong currently defaults to running on http,https,grpc,grpcs, but KIC defaults to http,https. I didn't immediately find where this default is coming from. Initial review of the KIC code indicates that it should just use whatever value is in the KongPlugin (or nothing if empty, allowing Kong to populate its default). decK does not have a standard constant default for it.

We should review the plugin handling code to determine where this value is currently being set, update it to reflect the current Kong default, and add the field to documentation.

@rainest rainest added bug Issues/PRs dealing with bugs in the docs area/docs labels May 12, 2021
@lahabana lahabana transferred this issue from Kong/kubernetes-ingress-controller Dec 17, 2024
@lahabana lahabana added team-k8s Kubernetes task tracking (including KIC,KGO) and removed bug Issues/PRs dealing with bugs in the docs onboarding area/docs labels Dec 17, 2024
@lahabana lahabana changed the title Review and document plugin protocols behavior KIC review and document plugin protocols behavior Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-k8s Kubernetes task tracking (including KIC,KGO)
Projects
None yet
Development

No branches or pull requests

3 participants