Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: hexadecimal reporting of addresses for the zh:ember:ezsp component. #25024

Open
antst opened this issue Dec 2, 2024 · 3 comments
Labels
feature request Feature request

Comments

@antst
Copy link

antst commented Dec 2, 2024

Is your feature request related to a problem? Please describe

I see in the logs next things
zh:ember:ezsp: Received network/route error ROUTE_ERROR_INDIRECT_TRANSACTION_EXPIRY for "4988"
zh:ember:ezsp: Received network/route error ROUTE_ERROR_SOURCE_ROUTE_FAILURE for "60899"

it would be lovely, if addresses would be in hex here, as everywhere else (particularly in UI) they are in hex.

Describe the solution you'd like

different formatting of the addresses

Describe alternatives you've considered

manual dec-hex conversion :)

Additional context

none

@antst antst added the feature request Feature request label Dec 2, 2024
@antst
Copy link
Author

antst commented Dec 2, 2024

I am not that big of the node expert, but I assume that replacing ${target} with ${target.toString('hex')} would work in relevant errors. Also the same for ${source}.
if that's OK, I can make this change

@Koenkk
Copy link
Owner

Koenkk commented Dec 3, 2024

Sounds like a good improvement, please make a PR

@antst
Copy link
Author

antst commented Dec 4, 2024

Sounds like a good improvement, please make a PR

I made PR #1252

It complains about code style issues with prettier though. But I don't feel comfortable to mess with it :) I am as far from nodes as one can be :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

2 participants